https://github.com/rust-lang/rust/pull/74361 just got merged however, people expressed concerns so we decided to merge it to fix the current issue and have a first version to debate upon.
An alternative suggested was to use an SVG image and then use CSS to change its color depending on the selected theme.
Another one was to force crates owners to provide multiple version of their logo for the different themes.
The last one was to change the CSS rule we used to something a bit "simpler".
I'm not a fan of the drop shadow look. I think either using SVG+CSS or alternate logos would be ideal. Crates should only really need to provide two logo versions: light and dark. I don't think that's too much to ask for (and if they only provide one image, it can be used for both light and dark).
Where can I test it? My first first impression is a definitive A+, but I would like to check if it works with add-ons like dark-reader (that I'm using). Currently, it looks like this for me:
Obviously it's anything but perfect (I need to know where the logo it in order to click it), so anything is probably going to be better.
Providing two versions of a logo seems too much for me. For now we only have 3 themes, but what happens if we had a fourth one which ends up with the same result? Do we have to suddenly ask for a third version of the logo? I feel strongly against it.
No, there should only ever be "light" and "dark" themes. Right now there are 2 dark themes and 1 light theme. A future hypothetical fourth theme should fall in either the "light" or "dark" categories.
And before you mention hypothetical colored themes: I don't think a theme's hue should be user-selectable. It should be selected at build time (in which case the crate author knows which color(s) to use/not use). The user should only be able to toggle between light/dark modes.
You don't take into account the fact that you can add your own theme. Also, it's pretty common to redshift themes or some other ones that makes the reading experience and that don't go into "dark" or "light" themes categories.
I can ask the same: can you show an example where the current fix doesn't solve the problem?
In the current case, it requires one line of CSS. In your case, it requires to generate multiple version of your logo (I'm pretty sure docs.rs people will really love this idea haha, cc @jyn514).
The drop shadow does solve the problem. I'm not saying it doesn't. I just don't think it's an ideal solution. It doesn't look as good/clean as having separate light/dark logos.
I see. Well, I really have a problem with having multiple logos for multiple reasons. I was mostly hoping that someone came up with a magical CSS add which would solve all issues. :3
If you don't mind absolutely destroying logos which aren't flat black/white, there's filter: invert(100%)
(Actually, it might be a solution to invert the light mode logo for dark mode if one isn't present, but also allow a dark mode logo to be provided for logos where that is bad (or for color logos that work on both to opt out).)
IMHO, the drop shadow looks, to put it bluntly, quite bad. It doesn't fit in at all with the rest of RustDoc's design, which is very flat and doesn't use any dimensional design elements (such as drop shadows) anywhere else. It's pretty jarring.
As a crate maintainer, I would much rather provide multiple versions of my crate's logo for light and dark themes. I don't think that this would necessitate providing more variants as multiple themes are added — all the themes can basically be binned into "light background" and "dark background", and we can choose which logo to use based on that. If the logo looks equally good on light and dark backgrounds, the crate can just provide the same image twice. I'd much prefer this over having the drop shadow inflicted on my crates' logos.
In general, I think any solution that's based on RustDoc automatically adding something to the logo runs the risk of not looking nice with all logo designs. With that said, if having to provide multiple versions of the logo is deemed unnecessary, I think it would be much better to use a light-colored stroke or border around the logo, rather than a drop shadow — it would fit in much better with the rest of RustDoc's design language.
I think if it were a declarative option/attribute you could set on a logo, this would work great for a lot of black/white logos.
If a logo has colors, it seems like it would be less affected by the background changes, so I think making it opt-in is a good option for black/white logos.
Obviously it's anything but perfect (I need to know where the logo it in order to click it), so anything is probably going to be better.
