Move the platform independent part of net into core

lygstate · February 17, 2021, 3:41am

Specifically, the address manipulation part for IPV4 and IPV6 can be moved to core

rust-lang/rust/blob/master/library/std/src/net/addr.rs

#[cfg(all(test, not(target_os = "emscripten")))]
mod tests;

use crate::cmp::Ordering;
use crate::convert::TryInto;
use crate::fmt;
use crate::hash;
use crate::io::{self, Write};
use crate::iter;
use crate::mem;
use crate::net::{htons, ntohs, IpAddr, Ipv4Addr, Ipv6Addr};
use crate::option;
use crate::slice;
use crate::sys::net::netc as c;
use crate::sys_common::net::LookupHost;
use crate::sys_common::{AsInner, FromInner, IntoInner};
use crate::vec;

/// An internet socket address, either IPv4 or IPv6.
///

This file has been truncated. show original

So the bare-metal and network stack implementor care sharing same piece of code across library

bascule · February 17, 2021, 3:53am

RFC: Move `std::net::IpAddr` types into `core::net`.

rust-lang:master ← reitermarkus:core-net-types

opened 11:20AM - 06 Dec 19 UTC

reitermarkus

+80 -0

Make the `IpAddr`, `Ipv4Addr`, `Ipv6Addr`, `SocketAddr`, `SocketAddrV4`, `Socke…tAddrV6`, `Ipv6MulticastScope` and `AddrParseError` types available in `no_std` contexts by moving them into a `core::net` module. [Rendered](https://rust-lang.github.io/rfcs/2832-core-net-types.html) --- Implementation: https://github.com/rust-lang/rust/pull/104265

faern · February 17, 2021, 5:24pm

I'm trying to remove the blockers for doing this in Implement network primitives with ideal Rust layout, not C system layout by faern · Pull Request #78802 · rust-lang/rust · GitHub

The problem is that the current IpAddr structs are based on system representations that we can't have in core really. And we can't just merge the fix for that since a bunch of crates invalidly assumed the memory layout of the types So it's currently a waiting game. We have to find everyone who broke this API contract, patch them and wait for the usage of the broken crates to drop quite a lot.

system · May 18, 2021, 5:25pm

This topic was automatically closed 90 days after the last reply. New replies are no longer allowed.

Topic		Replies	Views
std::net::Ipv4Addr in core?	17	2622	March 5, 2020
pre-RFC: Convenience IP Address Constructors libs	1	919	March 25, 2019
Impl Step for Ipv{4,6}Addr libs	5	514	January 17, 2024
Unable to build over IPv6 only - requires IPv4 cargo	1	1856	June 19, 2019
Handling IP ranges in the net module libs	4	1818	March 25, 2019

Move the platform independent part of net into core

Related topics