Feedback on new rust documentation logo background

[bascule]

@GuillaumeGomez

There are multiple ways to implement this, but in case it's just a URL, it means adding JS code to handle this switch in the DOM, which is far from trivial because it means generating data for the JS to read so that it knows that it needs to switch the logo in certain conditions.

Or we could make the logo fully through CSS?

Doing it with CSS sounds fairly straightforward: you can have two <img> tags for each logo type, set some CSS class adjacent to logo-container like logo-light or logo-dark, and use a child selector to make one of the two <img> tags either display: none or not.

I guess somehow in there something (JS) needs to toggle that CSS class, but I wasn't able to figure out how the existing theming works (I didn't see any other changes to the DOM when the themes are toggled on cursory inspection).

[kornel]

If themes were controlled only by prefers-color-scheme, then this would work automatically:

<picture>
   <source media="(prefers-color-scheme: dark)" src="dark-logo.png">
   <img src="light-logo.png">
</picture>

a JavaScript theme switcher could use this markup by manipulating the <source media> attribute (without media attr the first source becomes enabled).

<picture> element has an advantage of loading only the visible image, instead of both.

[Aloso]

@GuillaumeGomez

So for the meantime until we find a solution that pleases everyone (I'm sure we can!), I'll only add the border (and remove the blurry effect on it) on the default logo, so custom logos will be back to no border like it was before. I'll send the PR today.

Thanks for doing this!

However, I think the default logo looks best on a dark background when inverted. If you only change the default logo, inverting it seems like the best solution to me.

[Uther]

I personally prefer the outlined logo to the inverted one. The inverted logo stand out too much on a dark theme

[josh]

Rather than attempting to bikeshed the easiest way to modify a Rust logo designed for a light background to work on a dark background, we should be asking the logo designer for a logo designed for a dark background.