Taking drastic measures, importing dependencies and patching them

cheako · July 31, 2019, 9:50pm

I just wanted to say, regrettably, this is the solution I've taken.

Looking at ash-tray, a helper wrapper around ash(from git master) and winit. When adding imgui I discovered that I could use the preexisting vkr-imgui. I needed to patch vkr to support the loading of ash primitives.

gitlab.com

cheako/ash-tray-rs/blob/d85ed84cd03b47fb6395a93fc5b93c1293a5bfcd/rebase-vkr.sh

#!/bin/sh

set -e

mkdir -p src
rsync -Ert --inplace --no-whole-file --delete upstream/vkr/vkr/src/. src/vkr
rsync -Ert --inplace --no-whole-file --delete upstream/vkr/vkr-imgui/src/. src/vkr_imgui
cp upstream/vkr/vkr-imgui/src/imgui.frag.spv upstream/vkr/vkr-imgui/src/imgui.vert.spv src

find src/vkr -name \*.rs \
        -exec sed -i \
        -e 's/crate::/crate::vkr::/g' \
        -e 's/ vkr::/ ash_tray::vkr::/g' \
        -e 's/^const DL_PATH: &.static str/const DL_PATH: \&str/' \
        {} \+
sed -i -e 's/(num::/(pub num::/g' src/vkr/vk.rs
sed -i -e 's/unsafe fn load/pub unsafe fn load/g' src/vkr/lib.rs
mv src/vkr/lib.rs src/vkr.rs

find src/vkr_imgui -name \*.rs \

This file has been truncated. show original

Ash-tray uses submodules and scripts to bring in usable versions of other crates. I couldn't find another way.

Of particular note is that the root of the crate in both ash and vkr is not the same as the base of the git tree and currently cargo doesn't support git subfolders.

ExpHP · July 31, 2019, 10:18pm

I have no idea what you're saying in this thread or what you're trying to show us. Let's start from a simpler place: what is the thing that you wish could work, that currently does not? (And what is the expected behavior?)

I don't know what you mean? For git dependencies, Cargo will search the repo for the correct Cargo.toml.

Tom-Phinney · July 31, 2019, 10:51pm

There is a reason RalfJung wrote in another thread:

The internals forum is intended to discuss problems with, and proposed enhancements to, Rust's compiler and related tooling. Questions about using Rust belong in the Rust users forum.

system · October 29, 2019, 11:03pm

This topic was automatically closed 90 days after the last reply. New replies are no longer allowed.

Topic		Replies	Views
Regression report stable-2016-03-03 vs. beta-2016-03-03	3	1620	March 25, 2019
1.2 RC testing	6	2138	March 25, 2019
Idea: Resolving semver for packages with dates cargo	4	732	June 11, 2019
Barriers and Two-phase Borrows in Stacked Borrows Unsafe Code Guidelines	5	1258	March 28, 2019
Phantom dependencies language design	8	946	October 19, 2022

Taking drastic measures, importing dependencies and patching them

Related Topics