Regression report stable-2016-08-16 vs. beta-2016-09-21

[brson]

• From: stable-2016-08-16
• To: beta-2016-09-21

Coverage

• 6263 crates tested: 4112 working / 1826 broken / 17 regressed / 5 fixed / 303 unknown.

Regressions

• There are 14 root regressions
• There are 17 regressions

Root regressions, sorted by rank:

• slog-1.0.0 (before) (after)
• vnc-0.4.0 (before) (after)
• nanomsg-sys-0.6.0 (before) (after)
• gluon-0.1.3 (before) (after)
• zmtp-0.6.0 (before) (after)
• carp-0.1.0 (before) (after)
• hal-0.0.6 (before) (after)
• colerr-1.0.0 (before) (after)
• crowbook-0.8.0 (before) (after)
• bins-1.2.0 (before) (after)
• pentry-0.1.0 (before) (after)
• aluminum-0.3.0 (before) (after)
• pmem-0.1.0 (before) (after)
• boiler-0.1.1 (before) (after)

Full report.

I've only looked through a few so far but they looked legit. This release is scheduled to go out next Thursday.

[eddyb]

Most of them have to do with as_ref+String fallout.
The odd one is nanomsg-sys, which is an ICE - not sure if it has been reported so far.

[brson]

• "failed to read X/Cargo.toml" - slog, vnrc, hal, pmem
• ICE - nanomsg-sys
• "type annotations required: cannot resolve" - gluon, zmtp, carp, crowbook, bins, aluminum
• "the lifetime parameter 'a is not constrained by the impl trait, self type, or predicates" - colerr
• rustc overflowed stack! - pentry, boiler

[bluss]

gluon is fixed in git.

[brson]

@eddyb what is the deal with as_ref + String?

[bluss]

Explained in issue Lint against using generic conversion traits when concrete methods are available

[brson]

@bluss Do you know which change broke as_ref + String?

[bluss]

I thought it was https://github.com/rust-lang/rust/pull/35054 new From impl for String

[brson]

Yes, and reported https://github.com/rust-lang/rust/issues/36352 and subsequently closed.

[brson]

zmtp at least doesn't look like the same type inference error: "type annotations required: cannot resolve std::borrow::Cow<'_, str>: std::borrow::Borrow<_>"

[brson]

The "failed to read X/Cargo.toml" errors are false positives due to crater's inability to munge Cargo.toml workspaces usefully. This could become problematic for crater's continued usefulness.

[brson]

I can't repro the nanomsg-sys ICE.

[brson]

OK, so here's a new summary:

• colerr says "the lifetime parameter 'a is not constrained by the impl trait, self type, or predicates". Caused by https://github.com/rust-lang/rust/pull/35143.
• gluon, zmtp, carp, crowbook, bins, aluminum all fail because of a new From impl on String.
• I can't reproduce the nanomsg-sys ICE!
• pentry and boiler are both overflowing the stack. This was thought to be fixed by increasing the stack size to 16MB. It's not clear why it isn't. I can't reproduce.

[brson]

I can't even repro the stack overflows inside of a container using crater's docker image

[brson]

I've started a crater run to test the impact of reverting https://github.com/rust-lang/rust/pull/35054