I've only looked through a few so far but they looked legit. This release is scheduled to go out next Thursday.
Most of them have to do with as_ref+String fallout.The odd one is nanomsg-sys, which is an ICE - not sure if it has been reported so far.
gluon is fixed in git.
@eddyb what is the deal with as_ref + String?
Explained in issue Lint against using generic conversion traits when concrete methods are available
@bluss Do you know which change broke as_ref + String?
I thought it was https://github.com/rust-lang/rust/pull/35054 new From impl for String
Yes, and reported https://github.com/rust-lang/rust/issues/36352 and subsequently closed.
zmtp at least doesn't look like the same type inference error: "type annotations required: cannot resolve std::borrow::Cow<'_, str>: std::borrow::Borrow<_>"
std::borrow::Cow<'_, str>: std::borrow::Borrow<_>
The "failed to read X/Cargo.toml" errors are false positives due to crater's inability to munge Cargo.toml workspaces usefully. This could become problematic for crater's continued usefulness.
I can't repro the nanomsg-sys ICE.
OK, so here's a new summary:
I can't even repro the stack overflows inside of a container using crater's docker image
I've started a crater run to test the impact of reverting https://github.com/rust-lang/rust/pull/35054