Regression report stable-2016-08-16 vs. beta-2016-09-21

1
  • From: stable-2016-08-16
  • To: beta-2016-09-21

Coverage

  • 6263 crates tested: 4112 working / 1826 broken / 17 regressed / 5 fixed / 303 unknown.

Regressions

  • There are 14 root regressions
  • There are 17 regressions

Root regressions, sorted by rank:

Full report.

I’ve only looked through a few so far but they looked legit. This release is scheduled to go out next Thursday.

2

Most of them have to do with as_ref+String fallout. The odd one is nanomsg-sys, which is an ICE - not sure if it has been reported so far.

3
  • “failed to read X/Cargo.toml” - slog, vnrc, hal, pmem
  • ICE - nanomsg-sys
  • “type annotations required: cannot resolve” - gluon, zmtp, carp, crowbook, bins, aluminum
  • “the lifetime parameter 'a is not constrained by the impl trait, self type, or predicates” - colerr
  • rustc overflowed stack! - pentry, boiler
4

gluon is fixed in git.

5

@eddyb what is the deal with as_ref + String?

6

Explained in issue Lint against using generic conversion traits when concrete methods are available

7

@bluss Do you know which change broke as_ref + String?

8

I thought it was https://github.com/rust-lang/rust/pull/35054 new From impl for String

9

Yes, and reported https://github.com/rust-lang/rust/issues/36352 and subsequently closed.

10

zmtp at least doesn’t look like the same type inference error: "type annotations required: cannot resolve std::borrow::Cow<'_, str>: std::borrow::Borrow<_>"

11

The “failed to read X/Cargo.toml” errors are false positives due to crater’s inability to munge Cargo.toml workspaces usefully. This could become problematic for crater’s continued usefulness.

12

I can’t repro the nanomsg-sys ICE.

13

OK, so here’s a new summary:

  • colerr says “the lifetime parameter 'a is not constrained by the impl trait, self type, or predicates”. Caused by https://github.com/rust-lang/rust/pull/35143.
  • gluon, zmtp, carp, crowbook, bins, aluminum all fail because of a new From impl on String.
  • I can’t reproduce the nanomsg-sys ICE!
  • pentry and boiler are both overflowing the stack. This was thought to be fixed by increasing the stack size to 16MB. It’s not clear why it isn’t. I can’t reproduce.
14

I can’t even repro the stack overflows inside of a container using crater’s docker image :frowning:

15

I’ve started a crater run to test the impact of reverting https://github.com/rust-lang/rust/pull/35054

1 Like
16

This topic was automatically closed 90 days after the last reply. New replies are no longer allowed.