Where does Cargo check manifest "license" value a standard SPDX expression?

tisonkun · April 1, 2022, 4:00pm

rust-lang/cargo/blob/b1636fc1e049e977ae542ec2b2191ffab075b049/src/cargo/util/toml/mod.rs

use std::collections::{BTreeMap, BTreeSet, HashMap, HashSet};
use std::fmt;
use std::marker::PhantomData;
use std::path::{Path, PathBuf};
use std::rc::Rc;
use std::str;

use anyhow::{anyhow, bail, Context as _};
use cargo_platform::Platform;
use cargo_util::paths;
use log::{debug, trace};
use semver::{self, VersionReq};
use serde::de;
use serde::ser;
use serde::{Deserialize, Serialize};
use toml_edit::easy as toml;
use url::Url;

use crate::core::compiler::{CompileKind, CompileTarget};
use crate::core::dependency::{Artifact, ArtifactTarget, DepKind};

This file has been truncated. show original

It seems that we only check that "license" field exists but not actually evaluate SPDX expression.

notriddle · April 1, 2022, 5:00pm

github.com

rust-lang/crates.io/blob/2e744af8573f90b9706fa72ccffe5a52f91e2fdc/src/models/version.rs#L191-L204

      
        
            fn validate_license_expr(s: &str) -> AppResult<()> {
                pub const PARSE_MODE: spdx::ParseMode = spdx::ParseMode {
                    allow_lower_case_operators: false,
                    allow_slash_as_or_operator: true,
                    allow_imprecise_license_names: false,
                    allow_postfix_plus_on_gpl: true,
                };
            
            
    spdx::Expression::parse_mode(s, PARSE_MODE).map_err(|_| {
                    cargo_err("unknown or invalid license expression; see http://opensource.org/licenses for options, and http://spdx.org/licenses/ for their identifiers")
                })?;
            
            
    Ok(())
            }

tisonkun · April 1, 2022, 11:59pm

Thank you!