Vec::contains should accept anything that T implements Borrow for

sid0 · 2017-06-27T20:30:57.403Z

Vec::contains accepts &T. HashSet::contains is more general: it accepts any &Q where T: Borrow<Q>.

This makes it inconvenient to use Vec::contains on a Vec<Vec<u8>> with static bytestring slices (and I assume similarly for Vec<String>.

Would you consider generalizing Vec::contains to accept the more general type accepted by HashSet::contains?

jsgf · 2017-07-02T19:01:01.399Z

(Looks like the next step is a PR.)

sid0 · 2017-07-03T01:04:04.197Z

github.com/rust-lang/rust

slice: allow [T]::contains to accept any Q where T: Borrow<Q>

by sid0 on 01:01AM - 03 Jul 17

1 commits changed 4 files with 32 additions and 6 deletions.

GolDDranks · 2017-07-03T05:57:44.087Z

I just bumped into this today. I’ve got a Vec<String>, and I’d like to use .contains("static string") instead of having to do something like .iter().any(|v| v == "static_string"). So a big thumbs up for this!

Letheed · 2017-07-03T14:09:49.845Z

People have asked for this before. It hasn’t happened yet because that’s a breaking change in cases where inference determines the concrete type of T. I agree it’s a bit ridiculous that we can’t use .contains("foo") on a Vec<String>, but yeah. See https://github.com/rust-lang/rust/pull/37761

system · 2019-03-25T08:28:42.029Z

This topic was automatically closed 90 days after the last reply. New replies are no longer allowed.