Pre-RFC: Take trait with impl for Default

[EliSnow]

Not sure if this has been proposed before, but it would be nice to have a Take trait as defined below:

trait Take {
    fn take(&mut self) -> Self;
}

This is inspired by the Option.take method, but to make it even more useful there could be an implementation for types which implement Default:

impl<D: Default> Take for D {
    fn take(&mut self) -> Self {
        mem::replace(self, Default::default())
    }
}

My motivation was wanting a way to check and clear a boolean flag in one step, then I thought the idea was generic enough it could apply to any Default type.

[skysch]

A similar method also exists as Cell::take. Looking at the impls of Default in std, this looks like it will work pretty much everywhere and be quite convenient.

Downside is if default is expensive and you’re just trying to move out quickly. Then you’re wasting time computing defaults when you don’t actually need them. Option and Cell don’t have this problem because the defaults are cheap.

EDIT: Actually, I don’t think &mut Cell is sensible to its purpose, so Cell::take has a different definition.

[gbutler]

Maybe the implementation should be on D : Default + Copy so that it will only be default implemented for Copy types that also implement default?

[mbrubeck]

A similar proposal previously:

Method .take() on Vec

This is a nice pattern that takes the idea of Option::take and extends it to Vec. /// Replace the value with an "empty" state and return the original value trait Take { fn take(&mut self) -> Self; } impl<T> Take for Vec<T> { fn take(&mut self) -> Self { ::std::mem::replace(self, Vec::new()) } } This is nice because it allows writing code that replaces a vector with a map of it (playground) Edited to actually use ownership semantics, where this matters: A vec of Strings f…

[stepancheg]

I’d deprecate Option::take instead.

mem::replace is usable enough.

Additinally, there’s nothing specific to “object” or to construction in this operation to make it a method.

So if we will have this operation, I’d prefer it to be global in mem namespace:

mem::take<T: Default>(ptr: &mut T) { ... }

(Same way forget or drop are global functions, not instance methods.)

[system]

This topic was automatically closed 90 days after the last reply. New replies are no longer allowed.