Labeling improvements @ GitHub

1

The labels for the issue and pull request tracker of GitHub just got improved with the ability to add emojis and descriptions. See: https://github.com/blog/2505-label-improvements-emoji-descriptions-and-more

I’ve added descriptions to all labels of the following repositories as best I could:

But I’m sure there’s room for improvements.

I’ve refrained for now from adding emojis as I’m not sure those would be helpful but we could do that… /discuss.

5 Likes
2

I have taken the liberty to make an improvement to the I-unsound tag, please feel free to change it back if it causes any problems

6 Likes
3

I do love emojis. =) Any chance to make our systems more light-hearted works for me. :rabbit: I wonder if we can use them to replace or supplement the A- (etc) labels.

4

The only problem is that the urls get changed when you change the label name so if we add emojis then links can break. But you can add emojis to the description as well without breakage =P

2 Likes
5

Oh, yeah, that won’t do.

6

:+1: to more emoji usage

7

C-bug -> C-:bug:

4 Likes
8

A little off-topic, but I wonder if you could darken the background of the “final-comment-period” tag so the text changes back to white. (I’ve changed it on rust-lang/rust already). Compare:

41_zrLV3F

  • Above: RFCs @ #207de5
  • Below: Rust @ #1e76d9
5 Likes
9

I think that looks better, all for it :+1:

10

If we could leave the T-teamname labels and the other rfcbot labels stable, that’d be good. Because they need to work across multiple repos they’re referenced with a string literal rather than a stable identifier.

11

Can you please give some notice if you add emojis to the S- labels (the PR ones)? They’re used by name both by bors (I think), highfive and the PR status tracking thing I’m working on.

As a side note, I’m not a big fan of having emojis on the label names: they don’t give any real benefit, and I frequently type label:A-something in the search bar (breaking my workflow).

5 Likes
12

I think the consensus so far is that we shouldn't add emojis due to the url breakage - I-unsound being the exception for now.

13

One possible use for emoiji labels:

I’ve been tagging issues for the trait working group with little sigils to give an estimate of sort of task it is:

  • :rocket: urgent change: well explained, ready to go, but time sensitive
    • Best if you have some time in the near term to hack on it immediately
    • Expect to get pinged regularly via gitter or IRC =)
  • :hammer_and_wrench: refactoring: clear goal, not time sensitive
    • Best if you have some time in the near term to hack on it
  • :microscope: exploration: this is going to take some tinkering
    • These tasks are best for getting to know the system
    • But they will require regular investments of time probably to get done, and maybe some back and forth on the best design

I wonder if we might make those into labels instead, and use the scheme more regularly. I’m not sure those symbols are the best, but I like using an emoji to make it stand out when scanning.

3 Likes
14

I think those particular emojis are quite nice the labeling idea as well. :+1:

15

However, please also keep in mind that emojis can be much less readable than plain text. Some examples:

I would read "C-:bug:" as "C-worm" and be really confused - is this about malware?

I'd read :rocket: as "this is rocket science: really hard to get right and it will probably blow up".

Emojis are cute :heart_eyes:, but frequently not very clear in their intent, IMHO.

9 Likes
16

I wouldn’t have minded the addition of emojis if there was or had been some way to define e.g. I-unsound as an alias for I-unsound 💥.

In particular, I find the use of emojis in this instance to be an impedance when I am using the keyboard to type in label names in the search box.

Update: (Oh, on review I see pietroalbini already said this above.)

2 Likes
17

@pnkfelix what worries me most is the frequency with which you need to type I-unsound =P

4 Likes
18

If its causing problems for anyone it should be changed back!

19

This topic was automatically closed 90 days after the last reply. New replies are no longer allowed.