The mem::forget RFC sets a bad precedent. I understand that we need a decision, the decision taken is one I’m totally ok with, but that RFC author did not engage with any suggested improvements to the RFC. No amendments at all (unless they are invisible), and no responses to any of the in-line text suggestions.
Core member posts text, waits three weeks, text accepted. This is not in the spirit of the RFC process, which tells us to build consensus and integrate feedback.
You should be more careful with the most important RFCs.
While I take your point, I think it’s also a bit overstated. The RFC garnered an enormous amount of comments, and the author was very active in the discussion. The vast majority of discussion and consensus-building was about whether to go in this overall direction, or in the direction of Leak or RcGuard. I think it’s fair to say that that was primarily what the debate was about?
Looking at the inline comments, the one that I think most demands response is the question about what guarantees we do provide about destructor execution. But I think that’s a separable concern, having made the big decision about whether to allow Rc-cycle-style leaks. I think it would be best addressed in a discuss thread or separate RFC.
Also, for what it’s worth, the transition to subteams and the final comment period, which should happen in the next few weeks, should go a long way toward protecting against this: if an RFC enters its final comment period but some existing comments have fallen by the wayside, that’s a chance for people to bring them back up and make sure they get addressed.
Just noting my disapproval of discussing the subteams here and not at the weekly meeting. It’s not clear to me why it had to be done here. Glad we’re making progress on it though.
Because when discussing people, it’s sometimes best to keep it private whenever possible. Technical discussions are all good, but it’s harder to discuss people openly in a public forum; nor should the core team have to.
The weekly team meeting is not a public forum, it is just a slightly larger group.
I mean that the minutes are public (and some of the people being discussed may be present in the weekly meeting)
Not every issue is minuted, we’ve skipped minuting of sensitive issues in the past. Some of the people being discussed will be at the core team meeting too.
Ah okay. Then I guess it could have been discussed in the weekly meeting too. shrug