Bootstrap warning "Use `--keep-stage-std` ..." persists even when the option is used

cushionbadak · January 4, 2024, 9:19am

A pull request Add `--keep-stage-std` to `x.py` for keeping only standard library artifacts by ecstatic-morse · Pull Request #77120 · rust-lang/rust · GitHub introduces an option --keep-stage-std for bootstrapping (./x), but it does not provide any meaningful action, but it is just another syntactic bloat of --keep-stage option.

As you can see in the pull request, it pipes the option --keep-stage-std value to config.keep_stage_std and flags.keep_stage_std, but I cannot find any unique functionality of config.keep_stage_std value compared to config.keep_stage.

~~I think keeping this option is unnecessary. Am I missing something?~~

~~Reference: Following is the only part~~ I found where config.keep_stage_std value used:

github.com

rust-lang/rust/blob/139fb2214675fed8143a12f6287a3a1e6e2e866d/src/bootstrap/src/core/build_steps/compile.rs#L141-L151


      
          if builder.config.keep_stage.contains(&compiler.stage)
              || builder.config.keep_stage_std.contains(&compiler.stage)
          {
              builder.info("WARNING: Using a potentially old libstd. This may not behave well.");
          
              copy_third_party_objects(builder, &compiler, target);
              copy_self_contained_objects(builder, &compiler, target);
          
              builder.ensure(StdLink::from_std(self, compiler));
              return;
          }

EDIT: I discovered another logic that distinguishes keep_stage and keep_stage_std:

github.com

rust-lang/rust/blob/090d5eac722000906cc00d991f2bf052b0e388c3/src/bootstrap/src/core/build_steps/compile.rs#L1255-L1270


      
          fn run(self, builder: &Builder<'_>) {
              let compiler = self.compiler;
              let target = self.target;
              let backend = self.backend;
          
              builder.ensure(Rustc::new(compiler, target));
          
              if builder.config.keep_stage.contains(&compiler.stage) {
                  builder.info(
                      "WARNING: Using a potentially old codegen backend. \
                      This may not behave well.",
                  );
                  // Codegen backends are linked separately from this step today, so we don't do
                  // anything here.
                  return;
              }

EDIT: changed the title from "Bootstrap option --keep-stage-std is meaningless" to "Bootstrap warning "Use --keep-stage-std ..." persists even when the option is used". I'm rethinking whether the option is actually meaningless. Sorry for the confusion.

From my understanding:

keep_stage copies third party objects and copy_self_contained_objects, skipping the compiler build
keep_stage_std also copies these objects but doesn't skip the compiler build.

I apologize for my earlier mistake. Let's discuss this option further. My initial misunderstanding and post on this forum were prompted by a persistent warning message from the bootstrapping script ./x. It shows "WARNING: Use --keep-stage-std if you want to rebuild the compiler when it changes", even if I use multiple --keep-stage-std options like ./x build compiler --keep-stage 0 --keep-stage 1 --keep-stage-std 0 --keep-stage-std 1. After researching on GitHub, I realized that this warning only depends on the keep_stage configuration, not the presense of keep_stage_std.

github.com

rust-lang/rust/blob/090d5eac722000906cc00d991f2bf052b0e388c3/src/bootstrap/src/core/build_steps/compile.rs#L821-L826


      
          if builder.config.keep_stage.contains(&compiler.stage) {
              builder.info("WARNING: Using a potentially old librustc. This may not behave well.");
              builder.info("WARNING: Use `--keep-stage-std` if you want to rebuild the compiler when it changes");
              builder.ensure(RustcLink::from_rustc(self, compiler));
              return;
          }

I find this rigid method of showing warning messages to be confusing and not straightforward.

system · April 3, 2024, 9:19am

This topic was automatically closed 90 days after the last reply. New replies are no longer allowed.

Topic		Replies	Views
Should `---keep-stage` handle missing stages? compiler	2	157	January 26, 2025
Still confused about the role/nature of stage0 compiler	9	3301	March 25, 2019
Dogfooding -Z build-std in rustbuild	25	3241	April 15, 2021
Compile exactly the same git hash as a nightly	11	1150	September 6, 2020
Stage0 recompiled std misses symbols like `__aarch64_ldadd4_relax` compiler	7	1662	July 22, 2023

Bootstrap warning "Use `--keep-stage-std` ..." persists even when the option is used

Related topics