The Rust Project needs much better visibility into important metrics

dikaiosune 2016-06-07 07:34:03 UTC #40

Just deployed an updated version to http://rusty-dash.com/. Nothing too exciting here, paying down a little debt, converting the UI to tabs to make new additions cleaner, and merging a PR from @chriskrycho (yay!).

Now that the main front-end blocker to adding new metrics has cleared, I need to take care of a few things on the backend (multiple repo support is needed for many of the new ideas), and hopefully I'll be back to pushing features later this week.

aturon 2016-06-07 16:51:31 UTC #41

Strong +1. I think there's a ton of potential here, and organizing it in this way is going to be essential.

dikaiosune 2016-06-07 17:04:11 UTC #42

Uploaded a mutli-view version last night. Deep links (like http://rusty-dash.com/issues) are broken because of the nginx config, but I'll fix that this evening.

aturon 2016-06-07 17:31:17 UTC #43

Ahha, I missed that -- looks awesome, well done!

Once we've gotten all the info on tabs that we want, then we can maybe work out what should go on the front page (as a kind of "overview").

dikaiosune 2016-06-07 17:47:03 UTC #44

Once we've gotten all the info on tabs that we want

That could be a little while -- I've got 37 issues open in the repo, and ~18 of them will require adding new data sources or analysis in addition to the presentation work. Several more will just need new views from existing data. An initial guess at what might be most useful for teams to have on the front page could be a very good way to help me prioritize which data sources & analyses to prioritize (hint hint).

EDIT: And thanks!

brson 2016-06-08 00:17:02 UTC #45

I read through the issues and prioritized them per my own preferences.

These are high-priority and small:

User-defined date range. Completing existing features.
Link to day's build failures. Ditto.
Release cadence. Just an easy thing to do, and an easy way to answer a common question.

These are high priority and big:

Assignees tab. Useful for project management and for users.
Hot issues. Relatively easy to implement.
Feature pipeline dashboard. This is probably what many of us want the most, but it's quite involved.

cyplo 2016-06-08 05:27:03 UTC #46

Hi ! Sorry for the drive-by comment, but I'm fascinated by all the things in the metrics world. Most of the stuff I've seen is based on some combination of Grafana+timeseries db (like InfluxDB). Do you think this combo might be useful here ? Either from just looking at how Grafana implemented things to actually using Grafana as a frontend and possibly joining forces with them on improving the graphing capabilities if needed ?

Grafana allows for the specified group of users to edit the dashboards, this might allow for the load on the changes to be spread a bit between people. Not sure if all the other requirements mentioned are met (e.g. histograms seem to be in the works still)

Hope this helps more than disrupts your flow.

dikaiosune 2016-06-08 06:24:56 UTC #47

Sounds like a plan, and thanks for taking the time to go over the issues!

I'm getting some help from @chriskrycho on how to wire up the date pickers in Ember, should have that done soon. In the meantime:

Added a list to recent buildbot failures (scroll down, at the bottom of the Buildbots page). Definitely needs a nicer way to present it, but this is a start.
Fixed "deep" links in the nginx configuration
Deployed the "Triage" tab with the GitHub search links, will expand this with new metrics soon
Added benchmarks game link to useful links page.
Merged a PR from @chriskrycho to start the process of putting in the tests which I've very negligently not-built while putting this together.

dikaiosune 2016-06-08 06:42:26 UTC #48

Grafana does look super slick! I will have to take a closer look, so thank you for sharing.

I see three main issues with adopting something like Grafana:

Their SQL support doesn't seem to be done yet (but I may be wrong here). Postgres performance, deployment, backup, etc. are just so stable, well understood, and supported on cloud platforms like AWS, and SQL is a second tongue for any data junkie. Having to move away from an RDBMS (basically Postgres) would be a very tough sell in my opinion, not just because of familiarity, but also because the data we're collecting isn't purely time series.
It turns out that throwing some graphs up is the easy part of this project! I do think that having community-editable visualizations would be awesome (and I have an open pipe-dream issue to build something rudimentary along those lines). But, as you can see in this thread, the most dire needs are for visualizations/reports which combine time series data with non-time-series relational analysis (see @brson's issue about a "hot" issues tab or a feature pipeline tracker). Which really makes the work here spill outside the traditional definition of "dashboard metrics."
Rust is really quite good at a lot of this work (a bit verbose for some, yes), and building something in Rust means that a) it can more easily get contributors from its own community, and b) we have yet another showcase of an area where Rust can excel. Both of which are great value-adds for a project like this on top of the useful information it can provide.

All that said, I'm not ideologically opposed to Grafana or any other off the shelf tool for that matter, I just haven't seen one which meets all of the needs here.

cyplo 2016-06-08 07:28:17 UTC #49

Indeed, the focus is on non-rdbms, timeseried databases.

Cool

I wholeheartedly agree.

Thanks a lot !

eddyb 2016-06-08 07:32:39 UTC #50

From IRC, regarding the build failure list:

"exception interrupted" is how buildbot stops everyone else when one fails, so they should never be listed

dikaiosune 2016-06-08 15:06:53 UTC #51

Thanks for posting this here so I didn't forget. Just deployed a new version which ignores failed builds with messages matching LIKE "%xception%nterrupted". The tweaked version is live (ping @brson).

dikaiosune 2016-06-09 07:36:24 UTC #52

Links to build failures (for nightlies on that tab and for auto builders on the buildbots tab) are done, as is a simple release cadence tracker on the landing page. Fresh code deployed to http://rusty-dash.com. @chriskrycho has promised to help me grok Ember a bit better to properly implement user-defined date ranges.

The scraper will take some time to grab all the data from the nightly builders, so that tab should be accurate by the morning.

brson 2016-06-10 00:31:10 UTC #53

Oh man I love seeing new progress on the dashboard.

The nightly failure links are perfect.

The failed build metrics on the buildbot page seem suspect. Only 4 in 24 hours? The graphs (particularly linux) look like there may be some gaps in the data.

dikaiosune 2016-06-10 01:28:16 UTC #54

I'm pretty sure that 4 overall fails isn't too unreasonable, there have been ~7 PRs merged in the last 24 hours, so it seems OKish to me that there are only 4 root build failures (excluding any that are cancelled before they finish because a failed build elsewhere in the cluster).

@retep998 brought up on IRC extending the window to 48 hours, what do you think about that?

arielb1 2016-06-10 09:00:10 UTC #55

I had 3 rustbuild failures, and each of them took about 2 hours.

brson 2016-06-10 18:23:12 UTC #56

OK by me.

retep998 2016-06-11 05:29:56 UTC #57

Looking at the buildbot failures just made me realize that the commit links for the cargo builders still lead to the rust-lang/rust repo which is definitely wrong for cargo.

dikaiosune 2016-06-11 05:43:41 UTC #58

And your comment made me realize that I need to either update the graphs to include non-auto builders, or I need to update the title for the charts. Thoughts, @brson?

brson 2016-06-15 11:16:30 UTC #59

The other builders aren't as important. It might be good to know the time it takes to build nightlies though.