After looking at https://github.com/rust-lang/rust/pull/57318
Has anybody ever seen negative diffs from rustfmt?
It eats so much space
Line lengths are not respected - even if the line fits into 100 characters perfectly it’s still broken.
Many formatting choices are very different from what was used in rustc previously.
Perhaps rustfmt config needs to be tweaked to use “One True Line Length” instead of “one length for wrapping this, another shorter length for wrapping that”?
I’d also change the config to make formatting closer to what was used previously.
I guess it’s a necessary evil to keep the formatting consistent, but (despite maybe sounding silly) I’m very unhappy that code I’m working on has to go through this, and I’ll enjoy working on code less and will have less motivation if the code looks that much different from what I’d personally write.