I think it’s quite feasible in the broad strokes. Some questions:
The tool then automatically posts a comment with a checklist of subteam members (
[ ] aturon), with a check meaning “I have reviewed”
Is this then edited directly by team members to induce state changes? I’m not familiar with GitHub’s setup for these checklists, but in the past I’ve only seen repo owners & issue openers able to edit them. Also, I think it’ll be slightly easier to implement if state changes are triggered by new comments, like
@rfcbot reviewed or something similar. Perhaps I’m misunderstanding the exact mechanic you’re picturing here.
Subteam members can post a comment with fcp: r- to lodge a formal (blocking) objection.
Regardless of the exact invocation (re: @nikomatsakis’s comment), are RFC PRs guaranteed to only be tagged with exactly one T-team label before FCP? If not, we’d need to establish some mechanic for letting the bot know which members need to sign off.
Also, should something like this plan to register specific objections? Like:
I don't think we've sufficiently fleshed out the various tradeoffs of red vs. yellow paint here.
Which would then save the
not-enough-bikeshed objection along with the remaining text of the comment as a more detailed explanation? It’d be simple enough to then do
@rfcbot not-enough-bikeshed to remove the blocking objection. If doing so, would this act in lieu of any sort of r+/r- framework? Or would it be in addition to the overall consensus review?
Motion to FCP completes when all subteam members have reviewed and all blocking objections have been addressed.
How should a bot like the proposed one handle FCP’s closing? A comment on the PR, pinging subteam members to merge?
Members can file vacations etc to not be included.
A specific workflow would need to be set up here. I’m quite glad that so far I haven’t needed to setup logins or user-facing authentication for the dashboard, so if this can come from GitHub or somewhere else, it’d be ideal from my perspective.
I think we should also have the ability to write f? @somebody-or-other and to have the bot place a “Feedback request” on that person’s personal dashboard.
This is definitely do-able, assuming it’s limited to subteam members. If opened up to the community, it presents a UI complication for individual dashboards. Hopefully GitHub ping emails are enough to get non-subteam folks’ attention?