pre-RFC, JoinHandle::try_join()

Nokel81 · 2018-08-01T16:52:33.683Z

I came across this while writing some tests and believe that it is also useful for software engineering outside of tests.

Currently, when a new thread is spawned, it returns a JoinHandle with which you can get the thread handle or join (wait for it to run to completion). What I am suggesting is the ability to test if a thread has finished or not.

It would have the following signature: pub fn try_join(self) -> Option<Result<T>>. I think that this would be useful for work sharing or even monitoring since you can get some information about the thread without blocking yours. (kill if it is running to long but still do work in the meantime).

cuviper · 2018-08-01T17:30:43.761Z

Can that be implemented portably? On Linux with glibc, I know of pthread_tryjoin_np, but that np indicates that this is non-Posix. I don’t know about the other unix-ish targets, let alone Windows and others.

cuviper · 2018-08-01T18:14:41.040Z

I found https://crates.io/crates/thread_tryjoin

It does use pthread_tryjoin_np, so this only works on Linux, but both linux-gnu and linux-musl should be fine. That crate is not trying to decode it into an Option as you suggest, so you’d have to interpret the EBUSY error yourself.

retep998 · 2018-08-15T21:07:56.677Z

try_join would be trivial on Windows. Just change the timeout to 0, or even some number if you want a join_timeout.

github.com

rust-lang/rust/blob/d679b57a3a234a75926f1ffc5fe088c7ad97daf0/src/libstd/sys/windows/thread.rs#L70




pub fn set_name(name: &CStr) {
    if let Ok(utf8) = name.to_str() {
        if let Ok(utf16) = to_u16s(utf8) {
            unsafe { c::SetThreadDescription(c::GetCurrentThread(), utf16.as_ptr()); };
        };
    };
}


pub fn join(self) {
    let rc = unsafe { c::WaitForSingleObject(self.handle.raw(), c::INFINITE) };
    if rc == c::WAIT_FAILED {
        panic!("failed to join on thread: {}",
               io::Error::last_os_error());
    }
}


pub fn yield_now() {
    // This function will return 0 if there are no other threads to execute,
    // but this also means that the yield was useless so this isn't really a
    // case that needs to be worried about.

system · 2019-03-25T08:30:38.144Z

This topic was automatically closed 90 days after the last reply. New replies are no longer allowed.