From the discussion it sounds like it's OK to add must_use to side-effect-free functions, and whenever it doesn't make sense to use a function without its returned value.
In particular, I've found @cuviper made the exact same PR I was going to do 
1 Like