Build breakage with Beta 1.15


#1

At first glance this looks intentional, but since betas will become the next stable I thought I’d report this breakage just in case.

Beta 1.15 broke some Piston dependencies, see https://travis-ci.org/johnthagen/rust-belt/jobs/185930156.

   Compiling piston2d-gfx_graphics v0.33.1
     Running `rustc --crate-name gfx_graphics /home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/piston2d-gfx_graphics-0.33.1/src/lib.rs --crate-type lib -g -C metadata=75d76b8688e18afc -C extra-filename=-75d76b8688e18afc --out-dir /home/travis/build/johnthagen/rust-belt/target/debug/deps --emit=dep-info,link -L dependency=/home/travis/build/johnthagen/rust-belt/target/debug/deps --extern shaders_graphics2d=/home/travis/build/johnthagen/rust-belt/target/debug/deps/libshaders_graphics2d-bc2d9ef6ede3fdc6.rlib --extern gfx_texture=/home/travis/build/johnthagen/rust-belt/target/debug/deps/libgfx_texture-cbc69ea5920b7c12.rlib --extern shader_version=/home/travis/build/johnthagen/rust-belt/target/debug/deps/libshader_version-6a60d77d44fb1501.rlib --extern rusttype=/home/travis/build/johnthagen/rust-belt/target/debug/deps/librusttype-8452b977757731aa.rlib --extern graphics=/home/travis/build/johnthagen/rust-belt/target/debug/deps/libgraphics-406f8b04d4a27e3d.rlib --extern draw_state=/home/travis/build/johnthagen/rust-belt/target/debug/deps/libdraw_state-e3c78368e0380b33.rlib --extern gfx=/home/travis/build/johnthagen/rust-belt/target/debug/deps/libgfx-bc8682e6b5dca942.rlib --cap-lints allow -L native=/home/travis/build/johnthagen/rust-belt/target/debug/build/miniz-sys-428121ff932ec089/out`
warning: `$crate` may not be imported
  --> /home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/piston2d-gfx_graphics-0.33.1/src/back_end.rs:30:1
   |
30 |   gfx_pipeline_base!( pipe_colored {
   |  _^ starting here...
31 | |     pos: ::gfx::VertexBuffer<PositionFormat>,
32 | |     color: ::gfx::VertexBuffer<ColorFormat>,
33 | |     blend_target: ::gfx::BlendTarget<::gfx::format::Srgba8>,
34 | |     stencil_target: ::gfx::StencilTarget<::gfx::format::DepthStencil>,
35 | |     blend_ref: ::gfx::BlendRef,
36 | |     scissor: ::gfx::Scissor,
37 | | });
   | |___^ ...ending here
   |
   = note: `use $crate;` was erroneously allowed and will become a hard error in a future release
   = note: this error originates in a macro outside of the current crate
warning: `$crate` may not be imported
  --> /home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/piston2d-gfx_graphics-0.33.1/src/back_end.rs:39:1
   |
39 | gfx_pipeline_base!( pipe_textured {
   | ^
   |
   = note: `use $crate;` was erroneously allowed and will become a hard error in a future release
   = note: this error originates in a macro outside of the current crate
error[E0432]: unresolved import ``
  --> /home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/piston2d-gfx_graphics-0.33.1/src/back_end.rs:30:1
   |
30 |   gfx_pipeline_base!( pipe_colored {
   |  _^ starting here...
31 | |     pos: ::gfx::VertexBuffer<PositionFormat>,
32 | |     color: ::gfx::VertexBuffer<ColorFormat>,
33 | |     blend_target: ::gfx::BlendTarget<::gfx::format::Srgba8>,
34 | |     stencil_target: ::gfx::StencilTarget<::gfx::format::DepthStencil>,
35 | |     blend_ref: ::gfx::BlendRef,
36 | |     scissor: ::gfx::Scissor,
37 | | });
   | |___^ ...ending here: no `` in the root
   |
   = note: this error originates in a macro outside of the current crate
error[E0432]: unresolved import ``
  --> /home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/piston2d-gfx_graphics-0.33.1/src/back_end.rs:39:1
   |
39 | gfx_pipeline_base!( pipe_textured {
   | ^ no `` in the root
   |
   = note: this error originates in a macro outside of the current crate
     Running `rustc --crate-name glutin /home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/glutin-0.7.0/src/lib.rs --crate-type lib -g -C metadata=d8622fff934e1e6e -C extra-filename=-d8622fff934e1e6e --out-dir /home/travis/build/johnthagen/rust-belt/target/debug/deps --emit=dep-info,link -L dependency=/home/travis/build/johnthagen/rust-belt/target/debug/deps --extern wayland_client=/home/travis/build/johnthagen/rust-belt/target/debug/deps/libwayland_client-ae57c133b796a03f.rlib --extern osmesa_sys=/home/travis/build/johnthagen/rust-belt/target/debug/deps/libosmesa_sys-de9c1bbf8a33f0ec.rlib --extern winit=/home/travis/build/johnthagen/rust-belt/target/debug/deps/libwinit-0b6cc373efcc504a.rlib --extern x11_dl=/home/travis/build/johnthagen/rust-belt/target/debug/deps/libx11_dl-959882191612d71d.rlib --extern lazy_static=/home/travis/build/johnthagen/rust-belt/target/debug/deps/liblazy_static-1b77b520c29e5601.rlib --extern shared_library=/home/travis/build/johnthagen/rust-belt/target/debug/deps/libshared_library-7046f0f739c6841c.rlib --extern libc=/home/travis/build/johnthagen/rust-belt/target/debug/deps/liblibc-dc606c6e08883b3a.rlib --cap-lints allow`
error: aborting due to 2 previous errors
Build failed, waiting for other jobs to finish...
error: Could not compile `piston2d-gfx_graphics`.

This built with the previous stable, so just want to be sure it was expected.

The actual problem has since been fixed in a new release of piston_window: https://github.com/PistonDevelopers/gfx_graphics/issues/317


#2

Yes, I believe this was intentional, hence the message:

   = note: `use $crate;` was erroneously allowed and will become a hard error in a future release

We use these messages when we fix bugs or make other small changes (we try to avoid large changes, naturally) that may impact working code. I don’t recall this particular change but I imagine it is part of the ongoing work to make use integrate more cleanly with macros and so forth.

Great! :slight_smile: