What is the process for amending an already accepted ACP? I'm currently writing the docs for an ACP of mine that was accepted Expose Float Masks, and realized that to create a much easier to understand example, a constant for the exponent bias would be quite useful. It also fits nicely given it would be another constant describing the encoding of the float, it would also likely require a name change to something like "Float Encoding Constants" . The feature gate hasn't entered nightly yet so no issues with renaming it since it is not officially named.
The implementor typically had some leeway to change and add things as long as it's not anything huge and follows the same general spirit.
So I'd just include it in your PR and mention why
1 Like
alr ty
Go ahead and include it in the PR, make it a separate commit for easy separability, and explicitly mention that it's something not covered by the ACP. Nominate the PR for libs-api (I-libs-api-nominated) to review the additional constant.
5 Likes